Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Checkout] Set Payment Method and Place Order Mutation #723

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented May 22, 2019

Description (*)

This matching the existing frontend checkout flow and allows capturing
additional information for fraud tools such as Kount when placing orders.

Fixed Issues (if relevant)

  1. [Checkout] Set Payment Method and Place Order Mutation #716

Manual testing scenarios (*)

  1. Create empty cart
  2. Add product to cart
  3. Set billing address (and shipping if cart is not virtual)
  4. Set shipping method (if cart is not virtual)
  5. Set payment method and place order via mutation
mutation setPaymentMethodAndPlaceOrder($cartId:String!, $methodCode:String!) {
  setPaymentMethodAndPlaceOrder(input: {
      cart_id: $cartId
      payment_method: {
          code: $methodCode
      }
  }) {    
    order {
      order_id
    }
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

This matching the existing frontend checkout flow and allows capturing
additional information for fraud tools such as Kount when placing orders.

Fixes magento#716
…yment-and-place-order-mutation

# Conflicts:
#	app/code/Magento/QuoteGraphQl/Model/Resolver/SetPaymentMethodOnCart.php
@naydav naydav force-pushed the feature/set-payment-and-place-order-mutation branch from 2c2c7ac to a8c60a5 Compare June 20, 2019 16:45
@magento-engcom-team
Copy link
Contributor

Hi @naydav, thank you for the review.
ENGCOM-5328 has been created to process this Pull Request
✳️ @naydav, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team magento-engcom-team merged commit 283b8dd into magento:2.3-develop Jun 21, 2019
@ghost
Copy link

ghost commented Jun 21, 2019

Hi @pmclain, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.